Project

Profile

Help

Bug #2081

Line endings are not normalized in library modules

Added by Michael Kay over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
XQuery conformance
Sprint/Milestone:
-
Start date:
2014-05-24
Due date:
% Done:

100%

Spent time:
-
Legacy ID:
Applies to branch:
Fix Committed on Branch:
Fixed in Maintenance Release:
Found in version:
9.5
Fixed in version:
9.5.1.6

Description

(Reported by Gunther Rademacher on saxon-help list)

Line endings are normalized in the main query module but not in library modules.

History

#1 Updated by Michael Kay over 2 years ago

  • Status changed from New to In Progress

Normalization of line endings is done in XQueryParser.normalizeLineEndings10 or normalizeLineEndings11, which are called from XQueryParser.makeXQueryExpression(), which only handles the main module and not library modules.

Comments in the code suggest incorrectly that it's done in QueryReader.readInputStream(), which would handle both main modules and library modules. But this code isn't invoked when the query is supplied as a string (as happens when reading queries from the QT3 test catalog, for example), so I suspect the invocation was moved for this reason. See also the incorrect comment about line endings in the javadoc for QueryModule.makeQueryModule.

It probably makes sense to leave the invocation in XQueryParser.makeXQueryExpression() for main modules, and to add an invocation in QueryParser.parseLibraryModule to handle library modules.

#2 Updated by Michael Kay over 2 years ago

  • Status changed from In Progress to Resolved

Fixed as suggested in the 9.5 and 9.6 branches.

#3 Updated by O'Neil Delpratt about 2 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100
  • Fixed in version set to 9.5.1.6

Bug fix applied in Saxon maintenance release 9.5.1.6

Also available in: Atom PDF