Bug #2758
closed
Redundant code for computing special properties of a system function call
100%
Description
I don't have any observed symptoms here but the code looks fishy.
The code for SystemFunction.getSpecialProperties (if not overridden in a subclass) does some complex tests on the function metadata and then always returns the value StaticProperty.NON_CREATIVE. It looks to me as if this result is probably correct, but the code used to reach it is therefore quite unncessarily convoluted.
Updated by Michael Kay almost 8 years ago
- Applies to branch 9.7, 9.8 added
- Fix Committed on Branch 9.7, 9.8 added
By comparing the 9.7 code with the 9.6 code, one can see what has happened here. In the course of reorganisation (from SystemFunctionCall to FunctionCall+SystemFunction), a condition in computeSpecialProperties() was quite correctly deleted, and whoever did this failed to notice that other code in the method thereby became redundant.
I shall remove the redundant code on both the 9.7 and 9.8 branches. I think this bug is symptomless.
Updated by Michael Kay almost 8 years ago
- Subject changed from Questionable code for computing special properties of a system function call to Redundant code for computing special properties of a system function call
- Status changed from New to Resolved
Updated by O'Neil Delpratt almost 8 years ago
- Status changed from Resolved to Closed
- % Done changed from 0 to 100
- Fixed in Maintenance Release 9.7.0.6 added
Bug fixed in maintenance release 9.7.0.6.
Updated by O'Neil Delpratt almost 7 years ago
- Fix Committed on Branch trunk added
- Fix Committed on Branch deleted (
9.8)
Please register to edit this issue
.