Project

Profile

Help

Bug #2805

closed

Incorrect code in LocalVariableReference.copy()

Added by Michael Kay almost 8 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Internals
Sprint/Milestone:
-
Start date:
2016-06-21
Due date:
% Done:

100%

Estimated time:
Legacy ID:
Applies to branch:
9.7, trunk
Fix Committed on Branch:
9.7, trunk
Fixed in Maintenance Release:
Platforms:

Description

In consequence of bug 2770, the code for VariableReference.copy() was changed in 9.7.0.6 to allow the copied variable reference to be bound to a new (copied) local parameter.

The code is clearly incorrect because it sets the binding property of the old variable reference, not the new one.

I tripped over this in 9.8 when testing the new LoopLifting logic. There are no known symptoms with 9.7, but the code is clearly wrong.

Actions #1

Updated by Michael Kay over 7 years ago

  • Category set to Internals
  • Status changed from New to Resolved
  • Assignee set to Michael Kay
  • Priority changed from Low to Normal
  • Applies to branch 9.7, 9.8 added
  • Fix Committed on Branch 9.7, 9.8 added

The code has now been corrected on the 9.7 and 9.8 branches.

I confirmed that this caused no regressions for QT3 tests.

Actions #2

Updated by O'Neil Delpratt over 7 years ago

  • % Done changed from 0 to 100
  • Fixed in Maintenance Release 9.7.0.7 added

Bug fix applied in the Saxon 9.7.0.7 maintenance release.

Actions #3

Updated by O'Neil Delpratt over 7 years ago

  • Status changed from Resolved to Closed
Actions #4

Updated by O'Neil Delpratt almost 7 years ago

  • Applies to branch trunk added
  • Applies to branch deleted (9.8)
Actions #5

Updated by O'Neil Delpratt almost 7 years ago

  • Fix Committed on Branch trunk added
  • Fix Committed on Branch deleted (9.8)

Please register to edit this issue

Also available in: Atom PDF