Project

Profile

Help

Bug #4816

closed

Misspelt property name: XsltCompiler.FastCompliation (.NET)

Added by Michael Kay over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Category:
.NET API
Sprint/Milestone:
-
Start date:
2020-10-30
Due date:
% Done:

100%

Estimated time:
Legacy ID:
Applies to branch:
10, trunk
Fix Committed on Branch:
10, trunk
Fixed in Maintenance Release:
Platforms:

Description

According to the documentation, the property name FastCompilation has been misspelt as FastCompliation.

Actions #1

Updated by Michael Kay over 3 years ago

This arises from https://stackoverflow.com/questions/64609315/how-to-get-warnings-from-schema-aware-xslt-using-saxon-api/64611632?noredirect=1#comment114245448_64611632

Actually, looking at the Java code, I'm not sure that setting FastCompilation to false achieves much. It sets the optimizer options to be what they are at Configuration level, which I would think has JIT=true.

Actions #2

Updated by O'Neil Delpratt over 3 years ago

  • Status changed from New to Resolved
  • Applies to branch 10, trunk added
  • Fix Committed on Branch 10, trunk added

Fixed typo on both Saxon 10 and trunk branches.

Actions #3

Updated by Michael Kay over 3 years ago

  • Status changed from Resolved to In Progress

Let's add some tests to see if the property actually has any effect...

I'll do this on the Java side.

Also, is it possible to retain the misspelt name as a deprecated synonym in 10.x (dropping it on trunk)?

Actions #4

Updated by O'Neil Delpratt over 3 years ago

Michael Kay wrote:

Let's add some tests to see if the property actually has any effect...

I'll do this on the Java side.

I will port junit tests to nunit when ready.

Also, is it possible to retain the misspelt name as a deprecated synonym in 10.x (dropping it on trunk)?

Added back the property, with obsolete status added.

Actions #5

Updated by Michael Kay over 3 years ago

Two other observations:

  • XsltCompiler on .NET lacks the method XsltCompiler.setJustInTimeCompilation()

  • XsltCompiler on .NET has a method GetUnderlyingCompilerInfo(), perhaps it should also have GetUnderlyingXsltCompiler() - and perhaps this applies to all the C# classes that are layered on top of Java s9api classes.

Actions #6

Updated by O'Neil Delpratt over 3 years ago

Michael Kay wrote:

Two other observations:

  • XsltCompiler on .NET lacks the method XsltCompiler.setJustInTimeCompilation()

Method added.

  • XsltCompiler on .NET has a method GetUnderlyingCompilerInfo(), perhaps it should also have GetUnderlyingXsltCompiler() - and perhaps this applies to all the C# classes that are layered on top of Java s9api classes.

I have added the underlying implementation object where required. Some class have the underlying object already as the property Implementation.

Actions #7

Updated by Michael Kay about 3 years ago

  • Status changed from In Progress to Resolved

This appears to have been resolved.

Actions #8

Updated by O'Neil Delpratt about 3 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100
  • Fixed in Maintenance Release 10.5 added

Bug fix applied to Saxon 10.5 maintenance release.

Please register to edit this issue

Also available in: Atom PDF