Project

Profile

Help

Support #5175

closed

Use error reporter set in Configuration in more places

Added by Radu Coravu 9 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Diagnostics
Sprint/Milestone:
-
Start date:
2021-11-24
Due date:
% Done:

100%

Estimated time:
Legacy ID:
Applies to branch:
10, 11
Fix Committed on Branch:
10, 11
Fixed in Maintenance Release:
Platforms:

Description

I set an "ErrorReporterFactory" in the COnfiguration using "net.sf.saxon.Configuration.setErrorReporterFactory(Function<Configuration, ? extends ErrorReporter>)".

I use the constructor "net.sf.saxon.query.DynamicQueryContext.DynamicQueryContext(Configuration)". The dynamic query context should get the error reporter from the configuration instead of creating a standard error reporter.

I think the same when creating a static query context "net.sf.saxon.Configuration.newStaticQueryContext()", the static query context should take its initial error reporter from the Configuration.

Actions #1

Updated by Michael Kay 9 months ago

Yes, you're probably right. It gets quite difficult to rationalise this stuff.

Actions #2

Updated by Radu Coravu 9 months ago

Right, right now I set the same error reporter on 3 different objects just to make sure although they are all created based on the configuration.

Actions #3

Updated by Michael Kay 9 months ago

I have replaced creation of a StandardErrorReporter with a call on Configuration.makeErrorReporter() in the following places:

on the 10 branch:

SchemaManagerImpl constructor
Controller c'tor
StaticQueryContext c'tor and reset()
DynamicQueryContext c'tor
AbstractResourceCollection.optionsFromQueryParameters()
CompilerInfo c'tor

on the 11 branch:

SchemaManagerImpl constructor
Controller c'tor
StaticQueryContext c'tor and reset()
DynamicQueryContext c'tor
AbstractResourceCollection.optionsFromQueryParameters()
ActiveSAXSource.deliver()
CompilerInfo c'tor
Actions #4

Updated by Radu Coravu 9 months ago

Thanks Michael.

Actions #5

Updated by Michael Kay 6 months ago

  • Category set to Diagnostics
  • Status changed from New to Resolved
  • Assignee set to Michael Kay
  • Applies to branch 10, 11 added
  • Fix Committed on Branch 10, 11 added

Marking this resolved with no further action. Note that the fixes already described will be present in 11.1 although not documented as such in the release notes.

Actions #6

Updated by Debbie Lockett 6 months ago

  • Fixed in Maintenance Release 11.1 added

Belatedly marking as fixed in 11.1. Waiting to close when fixed in next Saxon 10 maintenance release.

Actions #7

Updated by Debbie Lockett 5 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100
  • Fixed in Maintenance Release 10.7 added
  • Fixed in Maintenance Release deleted (11.1)

Bug fix applied in the Saxon 10.7 maintenance release.

Actions #8

Updated by Debbie Lockett 5 months ago

  • Fixed in Maintenance Release 11.1 added

Please register to edit this issue

Also available in: Atom PDF