Project

Profile

Help

Patch #1403

closed

Improve Sender.java to use nested exceptions

Added by Anonymous over 15 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Internals
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Legacy ID:
sf-2424126
Applies to branch:
Fix Committed on Branch:
Fixed in Maintenance Release:
Platforms:

Description

SourceForge user: vocaro

In Sender.java, nested exceptions are not used. This means that the exception that caused the problem is tossed out, making diagnosis difficult.

This patch improves the exception handling in Sender.java so that it propagates the original exception as a nested exception.

There may be other places in Saxon that need this improvement, but Sender.java is the one that was affecting me.


Files

Sender.patch (9.56 KB) Sender.patch Anonymous, 2008-12-13 16:24
Actions #1

Updated by Anonymous over 15 years ago

SourceForge user: mhkay

Thanks, I'll incorporate these. There's one I'm not quite sure about: the common case of an XML parser error around line 416. I'm not sure it's right to both include the nested exception and append its message. The standard error listener takes care of this by only appending the message from the nested exception if it's not already there in the primary message, but it still feels questionable.

Actions #2

Updated by Anonymous over 15 years ago

SourceForge user: nobody

"I'm not sure it's right to both include the nested exception and append its message."

If it were me, I would remove the appending of the message and leave the nesting of the exception.

Actions #3

Updated by Michael Kay almost 11 years ago

  • Status changed from New to Closed

I think this problem was fixed in antiquity,

Please register to edit this issue

Also available in: Atom PDF