Project

Profile

Help

Bug #3187

printing

Added by Jan Paul Stegeman over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Sprint/Milestone:
-
Start date:
2017-03-30
Due date:
% Done:

100%

Applies to JS Branch:
1.0
Fix Committed on JS Branch:
1.0
Fixed in JS Release:
SEF Generated with:
Company:
-
Contact person:
-
Additional contact persons:
-

Description

Hello,

You've been into contact with some of my colleagues at SaxonJS. I've run into something as well: printing.

I have been looking at an issue where the print functionality in our website did not work. After some investigation I noticed that SaxonJS "hijacks" the print functionality, SaxonJS.js:191 says:

window.print = function (str) {

  console.log(str);

};

So, any call to window.print() is just a redirect to console.log(). Without any possibility to use printing on our site.

I see two options:

  1. do not override window.print() and just use console.log() in stead

  2. provide the original window.print() functionality to another function on window, i.e. window.printOrg = window.print before overriding window.print()

Thanks,

Jan Paul

History

#1 Updated by Debbie Lockett over 1 year ago

  • Assignee set to Debbie Lockett
  • Found in version set to 1.0.0

Thanks for raising the bug. This is something I was half aware of (since the 1.0.0 release), and was wondering when someone might hit problems because of it! We'll get it fixed for the next release.

#2 Updated by Debbie Lockett over 1 year ago

  • Status changed from New to Resolved

Rather than overwriting window.print, our Saxon-JS function for logging is renamed saxonPrint.

#3 Updated by Jan Paul Stegeman over 1 year ago

Great! When can we expect this to be released?

Jan Paul

#4 Updated by Debbie Lockett over 1 year ago

  • Applies to JS Branch 1.0 added
  • Fix Committed on JS Branch 1.0 added

#5 Updated by Debbie Lockett over 1 year ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100
  • Fixed in JS Release set to Saxon-JS 1.0.1

Bug fix applied in Saxon-JS 1.0.1 maintenance release.

Please register to edit this issue

Also available in: Atom PDF Tracking page