Project

Profile

Help

Bug #3387

closed

Inverse character ranges in regular expressions

Added by Michael Kay almost 7 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
XPath Conformance
Sprint/Milestone:
-
Start date:
2017-08-11
Due date:
% Done:

100%

Estimated time:
Applies to JS Branch:
Fix Committed on JS Branch:
Trunk
Fixed in JS Release:
SEF Generated with:
Platforms:
Company:
-
Contact person:
-
Additional contact persons:
-

Description

I think the logic for handling inverse character ranges such as \P{L} may be incorrect.

For two-letter categories the logic is sound. The categories.json file gives a definition of Ll as

[["61","7A"],["B5","B5"],["DF","F6"],...

and to invert this we form the ranges corresponding to the gaps:

["0","60"],["7B","B4"],["B6","DE"],...

This only works if the ranges are in ascending order. For single-character categories such as L, we concatenate the subcategories, and the result is therefore the union of the gaps in the subcategories, when it should be the gaps in the union of the subcategories.

Oddly, I can't point my finger at tests that are failing as a result.

Actions #1

Updated by Michael Kay almost 7 years ago

The problem can be demonstrated by making a variant of test regex-syntax-091 as follows:

<test-case name="regex-syntax-0191b">
      <description>see regex-syntax-0001</description>
      <created by="Michael Kay" on="2012-11-07"/>
      <environment ref="regex-syntax"/>
      <test>
         <param name="regex" as="xs:string" select="'\P{P}*'"/>
         <param name="match" as="xs:string" select="'&#xb2;'"/>
         <param name="nonmatch" as="xs:string" select="'&#xab;'"/>
         <param name="delimiter" as="xs:string" select="','"/>
         <initial-template name="go"/>
      </test>
      <result>
         <assert>/true</assert>
      </result>
   </test-case>

The character xAB matches category Pi; therefore it matches P; therefore it should not match \P{P}. But it does match, because it falls into one of the gaps in the Pc subcategory.

Actions #2

Updated by Michael Kay over 6 years ago

  • Status changed from New to Resolved
  • Fix Committed on JS Branch Trunk added

Fixed on the trunk source. We now manage sets of integer ranges as a nested array [[1,3], [5,6]] rather than a flattened array [1,3,5,6]; this makes it easy to sort the ranges into order before computing the inverse ranges.

Note, from a performance perspective, having computed the expansion of something like \W once, we should probably remember it for future use: at present we are repeating the work every time we parse a regular expression containing this construct.

Actions #3

Updated by Debbie Lockett almost 4 years ago

  • Description updated (diff)
  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100
  • Fixed in JS Release set to Saxon-JS 2.0
Actions #4

Updated by Debbie Lockett almost 4 years ago

  • Category set to XPath Conformance

Please register to edit this issue

Also available in: Atom PDF Tracking page