Project

Profile

Help

Bug #5535

closed

Improve documentation for exposed node properties

Added by Norm Tovey-Walsh over 2 years ago. Updated 7 days ago.

Status:
Closed
Priority:
Normal
Category:
Documentation
Sprint/Milestone:
-
Start date:
2022-05-24
Due date:
% Done:

100%

Estimated time:
Applies to JS Branch:
Trunk
Fix Committed on JS Branch:
Trunk
Fixed in JS Release:
SEF Generated with:
Platforms:
Company:
-
Contact person:
-
Additional contact persons:
-

Description

The documentation about XDM nodes makes reference to the fact that we've added properties to some of the node types, but doesn't actually enumerate the properties that we expect to be public.

We should use the externs for the node classes to derive the public properties and document them.


Related issues

Related to SaxonJS - Bug #5494: Properties of attribute nodes have internal names which change from one release to anotherClosedNorm Tovey-Walsh2022-05-18

Actions
Actions #1

Updated by Norm Tovey-Walsh over 2 years ago

  • Related to Bug #5494: Properties of attribute nodes have internal names which change from one release to another added
Actions #4

Updated by Debbie Lockett 2 months ago

We also use our own classes for namespace and attribute nodes (see NamespaceNode and AttributeNode in src/nsnode.js), and these are not documented (but they probably should be).

Actions #5

Updated by Debbie Lockett 14 days ago

Changes committed on the main branch, for SaxonJS 3: I added documentation for NamespaceNode and AttributeNode in xdm/nodes. These internal classes are exposed on the SaxonJS object, and included in externs/Generated.js.

Actions #6

Updated by Debbie Lockett 7 days ago

  • Category set to Documentation
  • Status changed from New to Closed
  • Assignee set to Debbie Lockett
  • % Done changed from 0 to 100
  • Fixed in JS Release set to SaxonJS 3.0
  • Applies to JS Branch Trunk added
  • Fix Committed on JS Branch Trunk added

Bug fix applied in the Saxon 3.0.0-beta1 preview release.

I'm closing this issue, because I think the documentation (at https://www.saxonica.com/saxonjs/documentation3/index.html#!xdm/nodes) now covers everything we want it to:

  • AttributeNode and NamespaceNode are now fully documented.
  • Otherwise we use DOM Node classes to represent XML nodes, so users should refer to external documentation for those (e.g. https://developer.mozilla.org/en-US/docs/Web/API/Node).
  • We do only add a couple of our own properties (e.g. _saxonBaseUri, and _saxonDocUri) which may be exposed to users, but they are really for internal use (as indicated by the use of the underscore prefix), and should not be relevant for users, so they don't require "full" documentation. (Note that these property names do not appear in the externs files, because all code references use bracket notation, so there's no risk of renaming with the closure compiler.)

Please register to edit this issue

Also available in: Atom PDF Tracking page