Project

Profile

Help

Bug #6191

closed

Released SaxonCS artefact is a debug build

Added by Michael Kay 9 months ago. Updated 13 days ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Performance
Sprint/Milestone:
-
Start date:
2023-09-01
Due date:
% Done:

0%

Estimated time:
Legacy ID:
Applies to branch:
11, 12, trunk
Fix Committed on Branch:
12, trunk
Fixed in Maintenance Release:
Platforms:
.NET

Description

Email from Nick Trevor:

Sorry to reach out directly, but was wondering if you could help. I'm test the performance of SaxonCS and when running the benchmarks I am getting warned that the nuget package is a debug build which could impact performance. Is it possible to get a release package published to nuget?

//    * Assembly Benchmarks which defines benchmarks references non-optimized SaxonCS
        If you own this dependency, please, build it in RELEASE.
        If you don't, you can disable this policy by using 'config.WithOptions(ConfigOptions.DisableOptimizationsValidator)'

Actions #1

Updated by Norm Tovey-Walsh 9 months ago

It's always interesting trying to work out what options the Microsoft build tools really want you to use.

AFAICT, we are making release builds not debug builds (--configuration Release) but we also specify a DebugType of pdbonly in the .csproj file. I wonder if that's relevant?

It does appear that we are setting Optimize in the .csproj file to false. Perhaps we should set that to true.

Actions #2

Updated by Norm Tovey-Walsh 7 months ago

I've changed the defaut for Optimize to true.

Actions #3

Updated by Michael Kay 13 days ago

  • Status changed from New to Closed
  • Fix Committed on Branch 12, trunk added
  • Fixed in Maintenance Release 12.4 added

I'm closing this in the hope that the changes we made to the build fixed the problem. If not, please let us know.

Please register to edit this issue

Also available in: Atom PDF