Saxon

Legacy ID: #3036823 Legacy Poster: Kevin Rodgers (notorious_kev)

Using a single sql:connection to process a large number of queries using Oracle's JDBC driver (more than the server's OPEN_CURSORS limit) results in this error: ORA-01000: maximum open cursors exceeded That error can be prevented by ensuring that both the statement and result set are closed. Here's the patch: *** net/sf/saxon/sql/SQLQuery.java~Fri Jan 21 08:29:46 2005 --- net/sf/saxon/sql/SQLQuery.javaTue Mar 8 09:27:24 2005 *************** *** 186,191 **** --- 186,193 ---- int rowCode = pool.allocate("", "", rowTag); int colCode = pool.allocate("", "", colTag); + PreparedStatement ps = null; + ResultSet rs = null; try { StringBuffer statement = new StringBuffer(); statement.append("SELECT " + dbCol + " FROM " + dbTab); *************** *** 195,205 **** //System.err.println("-> SQL: " + statement.toString()); // -- Prepare the SQL statement ! PreparedStatement ps=connection.prepareStatement(statement.toString()); controller.setUserData(this, "sql:statement", ps); // -- Execute Statement ! ResultSet rs = ps.executeQuery(); // -- Print out Result Receiver out = context.getReceiver(); --- 197,207 ---- //System.err.println("-> SQL: " + statement.toString()); // -- Prepare the SQL statement ! ps = connection.prepareStatement(statement.toString()); controller.setUserData(this, "sql:statement", ps); // -- Execute Statement ! rs = ps.executeQuery(); // -- Print out Result Receiver out = context.getReceiver(); *************** *** 221,229 **** //System.out.println(rowEnd); out.endElement(); } ! rs.close(); ! ! if (!connection.getAutoCommit()) { connection.commit(); } --- 223,229 ---- //System.out.println(rowEnd); out.endElement(); } ! if (!connection.getAutoCommit()) { connection.commit(); } *************** *** 231,236 **** --- 231,248 ---- DynamicError de = new DynamicError("(SQL) " + ex.getMessage()); de.setXPathContext(context); throw de; + } finally { + try { + if (rs != null) + rs.close(); + if (ps != null) + ps.close(); + } catch (SQLException ex) { + DynamicError de = + new DynamicError("(SQL) " + ex.getMessage()); + de.setXPathContext(context); + throw de; + } } } }