Bug #2699: XSLTTestSuiteDriver doesn't exit for some merge tests - Saxon - Saxonica Developer Community

Actions

Send by e-mail Copy link

Bug #2699

closed

XSLTTestSuiteDriver doesn't exit for some merge tests

Added by John Lumley over 8 years ago. Updated over 8 years ago.

Status:

Closed

Priority:

Normal

Assignee:

O'Neil Delpratt

Category:

Sprint/Milestone:

9.7.0.5

Start date:

2016-04-05

Due date:

% Done:

100%

Estimated time:

Legacy ID:

Applies to branch:

9.7

Fix Committed on Branch:

9.7

Fixed in Maintenance Release:

9.7.0.5

Platforms:

Description

When running the XSLT 3 tests merge-072/-074/-077 the individual tests themselves complete, and the final result summary is printed to stderr, but the main program doesn't close, at least within an IntelliJ environment. It appears that these are the ONLY tests in the suite that cause this problem. I suspect some thread closing issue, but such arcane areas are beyond my ken.

Actions

Copy link

Updated by O'Neil Delpratt over 8 years ago

Status changed from New to In Progress
Assignee set to O'Neil Delpratt

Yes we are aware of this problem in the test suite driver. I had investigated this problem before the last maintenance release. I managed to narrow it down to a few tests in another test set, although I can't quite remember which one. I will try and look into this again now and report back shortly.

Thanks for identifying the test set.

Actions

Copy link

Updated by O'Neil Delpratt over 8 years ago

The test case merge-072 is causing the hanging:

  <test-case name="merge-072">
      <description>Merge failure, using the wrong collation.</description>
      <created by="Michael Kay" on="2015-09-10"/>
      <dependencies>
         <feature value="streaming"/>
      </dependencies>
      <test>
         <stylesheet file="merge-071.xsl"/>
         <param name="collation" select="'http://www.w3.org/2013/collation/UCA?lang=de;caseFirst=upper;alternate=shifted'"/>
      </test>
      <result>
         <error code="XTDE2220"/>   
      </result>
   </test-case>

Actions

Copy link

Updated by O'Neil Delpratt over 8 years ago

Project changed from 4 to Saxon
Status changed from In Progress to Resolved
Priority changed from Low to Normal
Found in version changed from 9.8 to 9.7 9.8
Applies to branch 9.7 added
Fix Committed on Branch 9.7 added

The problem was in the failing case of the xsl:merge not properly closing after an exception is thrown.

Bug fixed in the processorLeavingTail method of the MergeInstr class by calling the method iter.close which in turn notifies the thread created in the PushToPull mthod

Actions

Copy link