Bug #2752
closed
JS: nashorn references in core (browser) code
100%
Description
Domutuils.copyItem()#81 refers to @cloneNode()@, which is defined in @nashorn/xmldom/dom.js@. When running under a browser nashorn is not loaded, and if so would probably produce conflict as it use node constructors.
Will investigate further.
Updated by Debbie Lockett over 8 years ago
I'm aware of this issue with Node.cloneNode() too, but haven't worked out a solution yet. The browser DOM version of Node does have a cloneNode() method but it takes one argument. The nashorn version we're using takes 3 arguments, and does a bit more in setting the parent document (if I remember correctly). I was hoping to make a change to just use the one arg version for any platform (browser or nashorn or whatever), but haven't quite worked out how to do that/ where changes are needed.
Updated by Debbie Lockett about 8 years ago
- Status changed from New to Resolved
Closing, since these issues were actually resolved before the Saxon-JS 0.9 beta release. Note that:
-
in a number of places the use of Node.cloneNode() was replaced by Document.importNode() since this was actually better
-
since this bug was raised, we added checks on the platform (i.e. in browser or not) where relevant to allow for DOM differences, etc.
Updated by Debbie Lockett almost 8 years ago
- Status changed from Resolved to Closed
- % Done changed from 0 to 100
- Found in version changed from 9.8 to 0.9
- Fixed in version set to 0.9.1
Bug fix applied in the Saxon-JS 0.9.1 beta release.
Updated by Community Admin over 7 years ago
- Fixed in JS Release set to Saxon-JS 0.9.1
- Applies to JS Branch 0.9 added
- Fix Committed on JS Branch 0.9 added
Updated by Debbie Lockett over 7 years ago
- Fixed in JS Release changed from Saxon-JS 0.9.1 to Saxon-JS 0.9.0
Please register to edit this issue
Also available in: Atom PDF Tracking page
.