Bug #4546: Bad location information when @use-when expression in an imported module has a syntax error - Saxon - Saxonica Developer Community

Actions

Bug #4546

closed

Status:

Closed

Priority:

Normal

Assignee:

Category:

Diagnostics

Sprint/Milestone:

Start date:

2020-05-07

Due date:

% Done:

100%

Estimated time:

Legacy ID:

Applies to branch:

10, 9.9

Fix Committed on Branch:

10, 9.9

Fixed in Maintenance Release:

Platforms:

Description

Hi Mike,

If you run the attached stylesheet, you'll get a message like this:

Static error on line 9 column 32 of driver.xsl:
  XPST0003  Unmatched quote in expression
Unmatched quote in expression

The actual error is the missing quote in use-when on line 10 of module.xsl

I had to binary search my module to find the error :-)

Files

Download all files

driver.xsl (580 Bytes) driver.xsl		Norman Tovey-Walsh, 2020-05-07 12:27
module.xsl (435 Bytes) module.xsl		Norman Tovey-Walsh, 2020-05-07 12:27

Actions

Appears to be a side-effect of the fix for bug 2244 (yes, that's November 2014).

Fixed by changing the catch block in UseWhenFilter.processIncludeImport() to use err.maybeSetLocation() instead of err.setLocation().

Confirmed that we still get a sensible error message when the xsl:import has a bad @href, which was the subject of the original bug.

Actions

Subject changed from Unhelpful error message to Bad location information when @use-when expression in an imported module has a syntax error
Category set to Diagnostics
Status changed from New to Resolved
Assignee set to Michael Kay
Priority changed from Low to Normal
Applies to branch 10, 9.9 added
Fix Committed on Branch 10, 9.9 added