Project

Profile

Help

Bug #5141

closed

SaxonCS build is not running XQuery Update tests

Added by Michael Kay over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Build and release
Sprint/Milestone:
-
Start date:
2021-10-20
Due date:
% Done:

100%

Estimated time:
Legacy ID:
Applies to branch:
11, trunk
Fix Committed on Branch:
trunk
Fixed in Maintenance Release:
Platforms:
.NET, Java

Description

XQuery Update is largely untested in SaxonCS, except for a handful of unit tests.

The same was true for years in the old Saxon/.NET product, so it's possible that (a) it works perfectly without being tested, or (b) that no-one is actually using it...

Note that the XQuery Update tests have now been integrated into the qt3 test suite, but work is needed in the test driver to run these tests.

Actions #1

Updated by Michael Kay over 2 years ago

I have changed the QT3 test driver so it is now running XQuery Update tests. Most of the tests pass, with the following exceptions:

  upd-InsertExpressions - 1
  upd-DeleteExpressions - 3
  upd-fn-put - 7
  upd-RelationalDataUpdates - 1
Actions #2

Updated by Michael Kay over 2 years ago

  • Status changed from New to In Progress

Examining the first of the failures:

-s:upd-InsertExpressions -t:id-insert-expr-053

we get

System.Collections.Generic.KeyNotFoundException: The given key 'input-context' was not present in the dictionary.
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at TestDriver.QT3TestSuiteDriver.runTestCase(XdmNode testCase, XPathCompiler xpc) in /Users/mike/GitHub/saxon2020/src/test/cstestrunner/TestDriver/QT3TestSuiteDriver.cs:line 740

which looks likely to be a test driver bug.

With that fixed, we're down to 4 failures:

  fn-put-003
  fn-put-004
  fn-put-005
  fn-put-006
Actions #3

Updated by Michael Kay over 2 years ago

These tests attempt to "put" nodes other than document or element nodes, which Saxon does not support. The test driver needs to be a bit finer-grained in examining the test dependencies.

Actions #4

Updated by Michael Kay over 2 years ago

  • Status changed from In Progress to Resolved
  • Applies to branch 11, trunk added
  • Fix Committed on Branch trunk added

All XQuery Update tests now running (or omitted if not applicable).

No changes to the product were needed, only to the test driver.

Actions #5

Updated by Michael Kay over 2 years ago

Changes made to user documentation (changes11.xml) to reflect this.

Actions #6

Updated by O'Neil Delpratt about 2 years ago

  • % Done changed from 0 to 100
  • Fixed in Maintenance Release 11.1 added
  • Platforms Java added

Bug fix applied in the Saxon 11.1 release.

Actions #7

Updated by O'Neil Delpratt about 2 years ago

  • Status changed from Resolved to Closed

Please register to edit this issue

Also available in: Atom PDF