Bug #5630: Error cause is not set when IllegalStateException is thoron in ActiveSAXSource (Saxon 11) - Saxon - Saxonica Developer Community

Actions

Send by e-mail Copy link

Bug #5630

closed

Error cause is not set when IllegalStateException is thoron in ActiveSAXSource (Saxon 11)

Added by Octavian Nadolu over 2 years ago. Updated almost 2 years ago.

Status:

Closed

Priority:

Low

Assignee:

Michael Kay

Category:

Diagnostics

Sprint/Milestone:

Start date:

2022-08-03

Due date:

% Done:

Estimated time:

Legacy ID:

Applies to branch:

11, trunk

Fix Committed on Branch:

11, trunk

Fixed in Maintenance Release:

12.0, 11.5

Platforms:

Java

Description

In net/sf/saxon/resource/ActiveSAXSource.java, when an Exception is cached, an IllegalStateException is throwed. Maybe you can set the cause in the IllegalStateException and not print the exception stack trace.

Instead of:

} catch (Exception x) {
       x.printStackTrace();
       throw new IllegalStateException();

Do something like:

} catch (Exception x) {
        throw new IllegalStateException(x);

Actions

Copy link

Updated by Michael Kay over 2 years ago

Category set to Diagnostics
Status changed from New to Resolved
Assignee set to Michael Kay
Applies to branch 11, trunk added
Fix Committed on Branch 11, trunk added
Platforms Java added

Indeed, that's certainly an improvement. The code was probably added to diagnose some particular problem as a once-off. I'm not sure why we bother catching the fallback exception at all, but there may be a reason (perhaps connected with C#?) so I'll leave it in for safety on the 11.x branch, but take it out for 12.x.

Actions

Copy link