Saxon

Test NodeTest007-1 fails:

Saxon.Ejava.lang.IllegalArgumentException: Unsupported node type in DOM! XmlDeclaration instance System.Xml.XmlDeclaration

Fixed by skipping XmlDeclaration nodes in DomNodeWrapper.getFirstChild(). This fixes all the prod-NodeTest and prod-AxisStep failures.

Down to 51 failures:

31196 successes, 51 failures, 0 incorrect ErrorCode, 505 not run
Failing tests:
  fn-doc - 2
  fn-for-each-pair - 1
  fn-has-children - 4
  fn-id - 6
  fn-innermost - 7
  fn-outermost - 6
  fn-path - 2
  fn-string - 1
  fn-unordered - 2
  prod-AxisStep.preceding - 31
  prod-DirElemContent.namespace - 4
  misc-CombinedErrorCodes - 1
  app-FunctxFn - 2
  app-UseCaseNS - 2
  app-UseCaseSEQ - 1

Test preceding-2 again fails "XmlDeclaration instance System.Xml.XmlDeclaration". It seems DomNodeWrapper.ChildEnumeration is skipping this node when traversing forwards, but not when traversing backwards.

Down to 29 failures.

In the test driver, when creating an XmlDocument for a source document, we need to set doc.PreserveWhitespace = true;

However, this increases the number of test failures to 53, probably because we are not skipping whitespace text node children of the document node.

Changed getFirstChild and getNextSibling to skip these nodes: results now

31222 successes, 28 failures, 0 incorrect ErrorCode, 505 not run
Failing tests:
  fn-id - 6
  fn-transform - 18
  prod-CompAttrConstructor - 1
  prod-CompCommentConstructor - 1
  prod-CompPIConstructor - 1
  prod-CompTextConstructor - 1
  prod-DirElemContent.namespace - 4
  app-UseCaseNS - 2
  app-Walmsley - 2

fn-transform tests are crashing, for example

-s:fn-transform -t:fn-transform-14
in TestSet fn-transform
System.NullReferenceException: Object reference not set to an instance of an object.
   at Saxon.Hej.tree.util.Navigator.copy(NodeInfo node, Receiver out, Int32 copyOptions, Location locationId) in /Users/mike/GitHub/saxon2020/build/cs/Saxon/Hej/tree/util/Navigator.cs:line 343
   at Saxon.Impl.Dom.DomNodeWrapper.copy(Receiver out, Int32 copyOptions, Location locationId) in /Users/mike/GitHub/saxon2020/src/main/saxon-cs/engine/Saxon/Impl/Dom/DomNodeWrapper.cs:line 369

I think this is related to the change just made. When enumerating over the children of the document node (in DomNodeWrapper,ChildEnumeration), hasNext() is returning true, but next() is then returning null, because in fact the only remaining nodes are ignorable,

Solved this by making ChildEnumeration no longer implement LookaheadIterator, which means it gets wrapped in a LookaheadIterator when required.

Results now:

31230 successes, 16 failures, 0 incorrect ErrorCode, 505 not run
  fn-id - 6
  prod-CompAttrConstructor - 1
  prod-CompCommentConstructor - 1
  prod-CompPIConstructor - 1
  prod-CompTextConstructor - 1
  prod-DirElemContent.namespace - 4
  app-UseCaseNS - 2

The fn-id test failures are because the Dom method GetElementById does not recognize xml:id attributes.

The specification of the method says:

The DOM implementation must have information which defines which attributes are of type ID. Although attributes of type ID can be defined in either XSD schemas or DTDs, this version of the product only supports those defined in DTDs. Attributes with the name "ID" are not of type ID unless so defined in the DTD. Implementations where it is unknown whether the attributes are of type ID are expected to return null.

Reimplemented DomDocumentTree.selectID() to search the document using the descendant axis.

Test case

-s:prod-CompAttrConstructor -t:Constr-compattr-doc-1

is delivering the wrong result because whitespace text node children of the document node are not ignored when forming the string value of the document node.

The implementation of getUnicodeStringValue() is relying on the DOM property XmlNode.InnerText.

Fixed this by making getStringValue() of a document node concatenate the string values of the nodes on the child axis.

Now seeing failures:

  prod-DirElemContent.namespace - 4
  app-UseCaseNS - 2

The results for

-s:prod-DirElemContent.namespace -t:Constr-inscope-9

make it pretty clear what's wrong:

Actual results:
<new>
   <child1 xmlns:foo="http://www.example.com/parent1"
            xmlns:xmlns="http://www.w3.org/2000/xmlns/"
            attr="child"/>
</new>

On the SaxonCS 11 branch, I've added support for -tree:dom to the QT3 test driver and the initial results are:

31103 successes, 271 failures, 0 incorrect ErrorCode, 505 not run

Successfully retrofitted the changes. (Still getting one failure in fn-collection, but I get that with -tree:tiny as well).