Project

Profile

Help

Actions
Send by e-mail Copy link

Bug #5983

closed

Saxon.C.API/SaxonApiException.cpp calculates wrong strlen

Added by Andreas Oetjen almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Low
Assignee:
O'Neil Delpratt
Category:
C++ API
Start date:
2023-04-19
Due date:
% Done:

100%

Estimated time:
Applies to branch:
Fix Committed on Branch:
Fixed in Maintenance Release:
Found in version:
12.1
Fixed in version:
12.2
SaxonC Languages:
SaxonC Platforms:
SaxonC Architecture:

Description

Lines 86ff:

if(sysId != nullptr) {
    //systemId = (char *)sysId;
    size_t destination_size = strlen(ec);
    systemId = (char *)malloc(sizeof(char)*destination_size);
    snprintf(systemId, destination_size, "%s", sysId);
} else {
    systemId = nullptr;
}

here strlen(ec) is wrong, it should be strlen(sysId), because this is what snprintf uses.

Actions
Copy link
 #1

Updated by O'Neil Delpratt almost 2 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Thanks for spotting this typo. Patched in the repo for the next maintenance release.

Actions
Copy link
 #2

Updated by O'Neil Delpratt almost 2 years ago

  • Status changed from Resolved to Closed
  • Fixed in version set to 12.2

Bug fix applied in the SaxonC 12.2 maintenance release.

Please register to edit this issue

Actions
Send by e-mail Copy link

Also available in: Atom PDF