Bug #6043: A zero-length command line argument causes an index out-of-bounds exception - Saxon - Saxonica Developer Community

Actions

Send by e-mail Copy link

Bug #6043

closed

A zero-length command line argument causes an index out-of-bounds exception

Added by Norm Tovey-Walsh 12 months ago. Updated 8 months ago.

Status:

Closed

Priority:

Low

Assignee:

Category:

Sprint/Milestone:

Start date:

2023-05-22

Due date:

% Done:

100%

Estimated time:

Legacy ID:

Applies to branch:

11, 12, trunk

Fix Committed on Branch:

11, 12, trunk

Fixed in Maintenance Release:

12.3, 11.6

Platforms:

Description

If you conspire to pass a zero length string to net.sf.saxon.Transform as a command line argument, we throw an index out-of-bounds exception.

(How, exactly, you do this is perhaps platform dependent, but it appears that on Windows at least java "" ... will result in a zero length string being passed as an argument.)

Then the question is, how should we react to this argument? Ignore it, or reject it and print the usage message? I'm leaning towards the latter.

Actions

Copy link

Updated by Norm Tovey-Walsh 12 months ago

This seems to work:

    public void setActualOptions(/*@NotNull*/ String[] args) throws XPathException {
        for (String arg : args) {
            if ("".equals(arg)) {
                throw new XPathException("An empty string is not a valid command line option");
            } else if ("-".equals(arg)) {
     ...

Anyone disagree with making it an error or the message?

Actions

Copy link