Saxon

The LocalParam class has two Expression fields (select and conversion), and its operands() method constructs Operand objects on demand to wrap these expressions. This is incorrect, and has the consequence that if any rewrite methods alter the select or conversion expressions, the rewritten expression is used to update the transient Operand object which is then discarded, so the change does not take effect.

This can be seen in action on the 9.8 branch in test as-1216, where the initializer for a template parameter is converted to a global variable, but the global variable reference is not written back to the LocalParam object.

The correct design is for the Operand objects to be fields of the LocalParam and for the underlying Expression objects to be fetched when required.