Saxon

The code works if the package is loaded from source, but not if it is loaded from an export file.

It appears that loading separately-compiled packages from export files has not been very thoroughly tested: we've tested export quite intensively against complete stylesheets, but not against library packages on their own.

(I also noted while developing this test that while APIs for loading the main stylesheet will accept either source XSLT or an export file, the same is not true for APIs that load library packages).

The test I am using to run this is:

            Processor processor = new Processor(true);
            XsltCompiler compiler = processor.newXsltCompiler();
            File file = new File("...../xslt30-test-B/tests/decl/override/override-m-021-base.sef");
            XsltPackage pack = compiler.loadLibraryPackage(file.toURI());
            System.err.println("Package loaded from " + file.getAbsolutePath());
            compiler.importPackage(pack);
            XsltExecutable exec = compiler.compile(new StreamSource(new File("...../xslt30-test-B/tests/decl/override/override-m-021.xsl")));
            DocumentBuilder db = processor.newDocumentBuilder();
            XdmNode root = db.build(new File("...../xslt30-test-B/tests/decl/override/override-m-021.xml"));
            Xslt30Transformer trans = exec.load30();
            StringWriter out = new StringWriter();
            Serializer ser = processor.newSerializer(out);
            trans.applyTemplates(root, ser);

I think the code should be checking for the visibility of the Mode component, not for its declaredVisibility. The two can be different, for example, as a result of xsl:expose or xsl:accept. The declared visibility is not captured in the export file, and I don't think it should be, because it is of no concern to a using package.

I have made the change suggested, and it works for this test without apparently causing any regression.

I have also changed the XSLT30 test suite driver so that if -export is specified, any packages named in the environment are exported and reimported before use.

This has led to three tests failing, where the package defines a decimal format: test cases override-misc-004, -005, and -006.