Actions

Send by e-mail Copy link

Bug #3333

closed

Using an XSLT 3.0 package indirectly by several routes

Added by Mark Dunn over 7 years ago. Updated over 7 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Michael Kay

Category:

XSLT 3.0 packages

Sprint/Milestone:

Start date:

2017-07-04

Due date:

% Done:

100%

Estimated time:

Legacy ID:

Applies to branch:

9.8

Fix Committed on Branch:

9.8

Fixed in Maintenance Release:

9.8.0.4

Platforms:

Description

I'd like to be able to create a single package of common functions, variables, etc.

Something like this:

<xsl:package 
    xmlns:xsl="http://www.w3.org/1999/XSL/Transform" 
    xmlns:xd="http://www.oxygenxml.com/ns/doc/xsl" 
    xmlns:xs="http://www.w3.org/2001/XMLSchema" 
    name="http://www.oup.com/oup-academic-common-package"
    package-version="0.1"
    version="3.0">
        
    <xsl:use-package name="http://www.oup.com/logger" package-version="0.1"/>
    <xsl:use-package name="http://www.oup.com/generalVariables" package-version="0.1"/>
    <xsl:use-package name="http://www.oup.com/getDTD" package-version="0.1"/>
        
</xsl:package>

Both "logger" and "getDTD" packages need to use the "generalVariables" package.

The "generalVariables" package also needs to be available to the stylesheet that uses the "oup-academic-common-package".

My first attempt threw up duplicate variable error messages.

Then I had a go with xsl:accept. So now both the "logger" and "getDTD" packages contain this statement:

  <xsl:use-package name="http://www.oup.com/generalVariables" package-version="0.1">
    <xsl:accept component="*" names="*" visibility="private"/>
  </xsl:use-package>

Now my error message is:

java.lang.AssertionError: Saxon can't find the new component corresponding to variable oupdtg:filePathSeparator

oupdtg:fileSeparator is a variable defined in the "generalVariables" package:

<xsl:package 
    xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
    xmlns:xs="http://www.w3.org/2001/XMLSchema" 
    xmlns:xd="http://www.oxygenxml.com/ns/doc/xsl"
    xmlns:oupdtg="http://www.oup.com/oupdtg" 
    name="http://www.oup.com/generalVariables"
    package-version="0.1"
    exclude-result-prefixes="#all"
    version="3.0">
    
    <xsl:variable name="oupdtg:newLine" as="xs:string" visibility="public">
        <xsl:text>&#x000d;&#x000a;</xsl:text>
    </xsl:variable>
    
    <xsl:variable name="oupdtg:quot" as="xs:string" visibility="public" select="'&quot;'"/>

    <xsl:variable name="oupdtg:filePathSeparator" as="xs:string" visibility="public" select="'[\\/]'"/>
     
</xsl:package>

If I use the three packages directly within my stylesheet (rather than wrapping them in the "oup-academic-common-package", the stylesheet works fine.

But is it possible to create this wrapper package?

Files

test-packages.zip (6.65 KB) test-packages.zip

Stylesheets and packages for testing use-package hierarchy and visibility

Mark Dunn, 2017-07-05 09:59

Related issues

Actions

Copy link

Updated by Michael Kay over 7 years ago

I think I need to see the source code (or a repro that demonstrates the problem) to understand what's going on here.

If something is public in generalVariables then it should become private within the packages that use it, so this conflict shouldn't happen -- in theory.

The code in this area hasn't had a large amount of exposure except to synthetic small-scale test cases so my instinct is to suspect a bug somewhere: in which case I will need a repro to investigate.

Actions

Copy link

Updated by Mark Dunn over 7 years ago

File test-packages.zip test-packages.zip added

I've attached a set of files with two top-level stylesheets, which illustrate a couple of scenarios.

test-xslt3-packages-1.xsl¶

Uses "oup-academic-common-package", which uses "logger", "generalFunctions", "generalVariables", and "runner".

"logger" uses "generalVariables"

"generalFunctions" uses "generalVariables"

Error message:

javax.xml.transform.TransformerConfigurationException: net.sf.saxon.s9api.SaxonApiException: Duplicate variable oupdtg:city

test-xslt3-packages-2.xsl¶

Uses "runner", which uses "logger" and "generalFunctions".

Error message:

java.lang.AssertionError: Saxon can't find the new component corresponding to variable oupdtg:city

Also included is an Ant build file and a batch file which I used to run the transformations using Saxon 9.8 HE. The error messages were the same using both methods of running the transformations.

Actions

Copy link

Updated by Michael Kay over 7 years ago

Sorry for the delay in responding. I've added some internal tracing to the code to show what's going on (it would seem a good idea to productize this). For the first case (packages-1) we have

Adding components from http://www.oup.com/generalVariables to http://www.oup.com/logger

variable oupdtg:city (PUBLIC) becomes PRIVATE