Saxon

Further, fix made by adding a clause in the XdmValue.Wrap when the value is indeed an ObjectValue which needs wrapping to a XdmExternalObject

I don't think this issue is fixed. First, I don't see what's the point of having XdmAtomicValue.WrapExternalObject when you can just do new XdmExternalObjectValue(o), but I understand back compat reasons. WrapExternalObject calls XdmValue.Wrap, which returns XdmExternalObjectValue, which is not an XdmAtomicValue, so WrapExternalObject always fails.

Also, WrapExternalObject wraps the argument using DotNetObjectValue, which is then passed to XdmValue.Wrap, which passes the argument to the XdmExternalObjectValue constructor, which wraps the argument again, this time using ObjectValue (not DotNetObjectValue). So, the external object is wrapped twice.

Even if you don't use WrapExternalObject and use XdmExternalObjectValue directly, this has the consequence that when trying to obtain the external object (in an extension function) I call GetExternalObject but get ObjectValue, so I have to call getObject on that. This is because XdmValue.Wrap is used to turn the Sequence into an XdmValue.

I hope you can apply fix to 9.7

Hi Max,

Thanks for your comments. The XdmAtomicValue.WrapExternalObject method should be removed because as you have mentioned it just won't work with the new XdmExternalObjectValue class which was introduced.

Likewise the XdmValue.Wrap needs fixing too. This has now been done. Here we unwrap the ObjectValue first before we pass the object as argument to the XdmExternalObjectValue. The Wrap method was designed to create XdmValue from underlying Saxon Sequence objects.

More nunit tests added