Saxon

There was a change here between XSD 1.0 and XSD 1.1 In 1.0, the value constraint includes the typed value only; in 1.1 it contains both the lexical form and the typed value. Along with this, 1.1 drops the concept of "canonical lexical representation". This resolves issues as to how lexical facets such as "pattern" should be handled: it is now clear that they apply to "lexical form" as supplied (after whitespace normalization), not to the result of converting the typed value back to its lexical representation.

For an Element declaration (but not for an Attribute Declaration or Attribute Use) we are holding both the typed and lexical forms of the default value. But the lexical form we retain is obtained as the canonical lexical form, not the original supplied form.

The change described in comment #2 is not quite right: for list types at least, it is outtputting the lexical-form of the fixed value in the form it was written in the source, not the form after applying the whitespace normalization rules. Test case MS/attribute/attO009 applies.

Applied a further fix: the method makeFixedValueTyped() in AttributeDecl, AttributeUse, and ElementDecl now sets the lexical form of the fixed value to the value after whitespace normalization.

Here are the XSD test suite failures:

<out xmlns:saxon="http://saxon.sf.net/"
     on="2018-11-14T16:09:28.551Z"
     failed="28"
     queried="54">
   <test set="ElemDecl"
         group="valueconstraint00101m2"
         name="valueConstraint00101m2"/>
   <test set="ElemDecl"
         group="valueconstraint00401m2"
         name="valueConstraint00401m2"/>
   <test set="ElemDecl"
         group="valueconstraint00401m6"
         name="valueConstraint00401m6"/>
   <test set="ElemDecl"
         group="valueconstraint00401m8"
         name="valueConstraint00401m8"/>
   <test set="ElemDecl"
         group="valueconstraint00402m2"
         name="valueConstraint00402m2"/>
   <test set="ElemDecl"
         group="valueconstraint00402m6"
         name="valueConstraint00402m6"/>
   <test set="ElemDecl"
         group="valueconstraint00402m8"
         name="valueConstraint00402m8"/>
   <test set="ElemDecl"
         group="valueconstraint00601m2"
         name="valueConstraint00601m2"/>
   <test set="ElemDecl"
         group="valueconstraint00601m4"
         name="valueConstraint00601m4"/>
   <test set="ElemDecl"
         group="valueconstraint00601m6"
         name="valueConstraint00601m6"/>
   <test set="ElemDecl"
         group="valueconstraint00601m8"
         name="valueConstraint00601m8"/>
   <test set="MS-Attribute2006-07-15" group="attO002" name="attO002"/>
   <test set="MS-Attribute2006-07-15" group="attO003" name="attO003"/>
   <test set="MS-Attribute2006-07-15" group="attO005" name="attO005"/>
   <test set="MS-Attribute2006-07-15" group="attP006" name="attP006"/>
   <test set="MS-Element2006-07-15" group="elemD005" name="elemD005"/>
   <test set="MS-Element2006-07-15" group="elemZ012" name="elemZ012"/>
   <test set="MS-SimpleType2006-07-15" group="stZ070" name="stZ070"/>
   <test set="ID_IDREF" group="s3_3_4si01" name="s3_3_4si01s"/>
   <test set="ID_IDREF" group="s3_3_4si02" name="s3_3_4si02s"/>
   <test set="ID_IDREF" group="s3_3_4si03" name="s3_3_4si03s"/>
   <test set="ID_IDREF" group="s3_3_4si04" name="s3_3_4si04s"/>
   <test set="ID_IDREF" group="s3_3_4si05" name="s3_3_4si05s"/>
   <test set="ID_IDREF" group="s3_3_4si06" name="s3_3_4si06s"/>
   <test set="ID_IDREF" group="s3_3_4si07" name="s3_3_4si07s"/>
   <test set="ID_IDREF" group="s3_3_4si08" name="s3_3_4si08s"/>
   <test set="ID_IDREF" group="s3_3_4si09" name="s3_3_4si09s"/>
   <test set="ID_IDREF" group="s3_3_4si10" name="s3_3_4si10s"/>
</out>

The XSD test suite failures were caused by a simple error on an error-reporting path. Now fixed.

Now looking at the SCM issues.

(1) For an (element declaration, attribute declaration, or attribute use) with a fixed value we get

     <scm:fixed lexicalForm="23">
         <scm:item type="#integer" value="23"/>
      </scm:fixed>

(2) For an (element declaration, attribute declaration, or attribute use) with a default value we get

default="23"

The asymmetry is unfortunate. I think that where there is a default value we should output both the lexical form and the typed value in the same way as we do for fixed values (while retaining the representation as an attribute for backwards compatibility). Note that this involves a change to the schema for SCM.

I have made this change. All XSD tests again working.

I have now changed the code that tests attributes against a fixed value constraint to use the same logic (and indeed the same code) as that for elements. Specifically it compares the "schemaComparable()" comparison keys rather than doing a deepEquals() call.

All XSD tests passing.