Saxon

Also affects test id-rename-expr-033/034

Also id-replace-expr-045

Also mergeUpdates-001

I've now run these tests against 10.3 using the 10.x UpdateTestSuiteDriver, and surprisingly the tests appear to succeed.

More careful examination shows that this is a false positive. The comparison of actual results with expected results is actually failing with an IndexOutOfBoundsException, which is being ignored, so the test is reported as a pass when it should have reported a failure.

With this bug in UpdateTestSuiteDriver fixed, the following tests now fail on 10.3:

  id-insert-expr-086
  id-replace-expr-045
  id-rename-expr-033
  id-rename-expr-034

(But not merge-updates-001, so that might be a different problem).

When child elements are inserted, the InsertExpression and InsertAction object contain a flag to indicate whether namespace inheritance is in force (in the query static context), and it looks like the logic has been changed for the 10.0 namespace model to reflect this: the instruction ends up calling (or not calling) ((ElementImpl) child).fixupInsertedNamespaces(inherit); to handle the namespace inheritance.

By contrast, InsertAttributeAction has no flag for namespace inheritance. I suspect that under the old namespace model, namespace inheritance was always happening implicitly, and it is now never happening in the case of attribute insertion.

But RenameAction also has no flag for this.

So, I've been trying to find out how this ever worked, and I've discovered it never did. Looking back at 9.9, the RenameAction makes no attempt to distinguish between the inherit/no-inherit cases. It always (in effect) does "inherit", and the reason the no-inherit tests appear to work is because of the same bug in the UpdateTestSuiteDriver: the compare() method returns "true" when comparing an empty string with a non-empty string.